Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlt-logd-converter: Fix getting log level from log msg #456

Merged
merged 2 commits into from
Mar 20, 2023
Merged

dlt-logd-converter: Fix getting log level from log msg #456

merged 2 commits into from
Mar 20, 2023

Conversation

RobinChenJP
Copy link
Contributor

in AOSP, system/logging/liblog/logprint.cpp --> android_log_processLogBuffer:
entry->priority = static_cast<android_LogPriority>(msg[0])
msg[0] is used to obtain the log level

@RobinChenJP
dlt-logd-converter: Fix getting log level from log msg
804e05c 
In AOSP, system/logging/liblog/logprint.cpp --> android_log_processLogBuffer:
entry->priority = static_cast<android_LogPriority>(msg[0])
msg[0] is used to obtain the log level
@minminlittleshrimp
Copy link
Collaborator

minminlittleshrimp commented Mar 20, 2023 •
edited
Loading

Hello @michael-methner
Please approve and merge this PR since this is known issue.
Link: https://cs.android.com/android/platform/superproject/+/master:system/logging/liblog/logprint.cpp;l=562;drc=b6d7f3b484e4c32c144c66bee342c29e7a8d34cc
This issue could be clarify when we try to catch logs from logd.
Example: for the failed logs (which cannot be written to offline logs file), the log level which is retrieved from logd entries is 15 !!!
It causes the log level is out of the range of filter, hence there are no logs written to files.
Regards

@michael-methner michael-methner merged commit 28f0840 into COVESA:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-methner michael-methner michael-methner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobinChenJP @minminlittleshrimp @michael-methner